Skip to content

Added new pipelines commands (pipelines, streams, sinks, setup) [do not merge until 9/22] #10612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 22, 2025
Merged

Added new pipelines commands (pipelines, streams, sinks, setup) [do not merge until 9/22] #10612

merged 8 commits into from
Sep 22, 2025

Conversation

@jonesphillip
Copy link
Contributor

@jonesphillip jonesphillip commented Sep 11, 2025 •
edited by petebacondarwin
Loading

Added new pipelines commands (pipelines, streams, sinks, setup), moved old pipelines commands behind --legacy

Approval: CR-1299934

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c89c187

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 11, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10612

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10612

miniflare

npm i https://pkg.pr.new/miniflare@10612

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10612

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10612

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10612

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10612

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10612

wrangler

npm i https://pkg.pr.new/wrangler@10612

commit: c89c187

@jonesphillip jonesphillip marked this pull request as ready for review September 11, 2025 18:35
@jonesphillip jonesphillip requested a review from a team as a code owner September 11, 2025 18:35
penalosa
penalosa reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just sinks—still need to review streams

penalosa
penalosa reviewed Sep 15, 2025
View reviewed changes
penalosa
penalosa reviewed Sep 16, 2025
View reviewed changes
oliy
oliy approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@oliy oliy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from the perspective of New Pipeline API usage. Will have to defer to wrangler team for wrangler code/tool best practies.

@vicb
Copy link
Contributor

vicb commented Sep 16, 2025

Validate PR Description has a legit failure

image

@jonesphillip jonesphillip force-pushed the pjones/wrangler-pipelines-v1 branch from d52a462 to 344beee Compare September 16, 2025 17:33
@lrapoport-cf
Copy link
Contributor

lrapoport-cf commented Sep 16, 2025

as discussed with team, please wait to land till monday (9/22)

cc @jonesphillip @dario-piotrowicz @oliy

@jonesphillip jonesphillip changed the title Added new pipelines commands (pipelines, streams, sinks, setup) Added new pipelines commands (pipelines, streams, sinks, setup) [do not merge until 9/22] Sep 16, 2025
@penalosa penalosa added the blocked Blocked on other work label Sep 17, 2025
penalosa
penalosa reviewed Sep 17, 2025
View reviewed changes
packages/wrangler/src/pipelines/cli/streams/utils.ts
}),
config.configPath,
args.env,
false // Don't offer to update automatically
Copy link
Contributor

@penalosa penalosa Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set to true, ideally. Why don't you want the config file updated automatically?

penalosa
penalosa approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but this is still blocked on merging

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 17, 2025
@jonesphillip jonesphillip mentioned this pull request Sep 22, 2025
Merged
@petebacondarwin petebacondarwin force-pushed the pjones/wrangler-pipelines-v1 branch from da9e634 to c89c187 Compare September 22, 2025 15:21
@petebacondarwin petebacondarwin merged commit 97a72cc into main Sep 22, 2025
35 of 36 checks passed
@petebacondarwin petebacondarwin deleted the pjones/wrangler-pipelines-v1 branch September 22, 2025 16:06
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 22, 2025
@workers-devprod workers-devprod mentioned this pull request Sep 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliy oliy oliy approved these changes

@penalosa penalosa penalosa approved these changes

Assignees

@oliy oliy

@cmackenzie1 cmackenzie1

Labels

blocked Blocked on other work

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jonesphillip @vicb @lrapoport-cf @oliy @penalosa @petebacondarwin @cmackenzie1